Skip to content

Feature - Global Navigation Bar - #5

Open
pns-opswerks wants to merge 1 commit into
releasefrom
feat/global-navbar-3.1
Open

Feature - Global Navigation Bar#5
pns-opswerks wants to merge 1 commit into
releasefrom
feat/global-navbar-3.1

Conversation

@pns-opswerks

Copy link
Copy Markdown

Summary

Shared top nav for learners across LMS and MFEs (Dashboard, Library, History, Discover, Help + course search), so the header stays consistent instead of changing per page.

I profiled the component and the Header render time is approximately 2.1 ms / 500 ms**

Related Ticket / Issue

https://app.clickup.com/t/9016295640/PROJ-3470

Type of Change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore / Maintenance

What Changed?

  • One shared link set (Dashboard, Library, History, Discover, Help) on LMS theme + MFEs
  • Header search goes to /search (LMS + learner-dashboard)
  • New /library and /history pages to exercise those nav items
  • Nav layout (flexbox): one row with logo left, links + search pill centered in a growing middle zone, account/actions right so nav isn’t stuck under the logo; mobile keeps the same zones and hamburger won’t crash when the right-side control is a button (not a link list)
  • Mobile header fix for that button-as-secondary-menu case

How Was This Tested?

  • Unit tests
  • Integration tests
  • Manual testing
  • Not tested, explanation below:

Screenshots / Recordings

image
global-navbar-3.1.mov

Checklist

  • Code follows project standards
  • Tests were added or updated
  • Documentation was updated if needed
  • No secrets, credentials, or sensitive data were committed
  • I reviewed my own changes before requesting review

Notes for Reviewers

N/A

Release tip lacked these pages; required for HEADER_NAV_LINKS Library/History routes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant