Divide and conquer less threads #597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is' tread, instead of letting 'this' tread wait.
Programmer-Magnus
force-pushed
the
DivideAndConquer-LessThreads
branch
from
e64c1fe to
da909eb
Compare
|
I did evaluate this before, and got better throughput by "waisting" threads like this. (Maybe I was mistaken or maybe things have changed, it was a long time now – could re-investigate this.) Perhaps it's time to run some of the (subclasses of) AbstractThresholdTuner benchmarks again. In the end, I suppose, it's the results of the benchmarks in https://github.com/optimatika/ojAlgo-linear-algebra-benchmark that matter. |
|
I agree, accepting it should depend on the benchmark results produced. Result might depend on what java version the benchmark use. I will look at those tests you mention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Divide and conquer can use 'this' thread instead of creating a second thread and then wait for the two new ones to finish their tasks.
Test Cases
I only run the normal ojAlgo tests and only the testReading1BRC failed as it did for me before this patch.
I hope this will improve benchmarks slightly, but I do not know which to run.