-
Notifications
You must be signed in to change notification settings - Fork 32
[FSSDK-11372] assign holdoutIds to feature flags #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* master: [FSSDK-11371] parsing holdout section from the datafile (#577) # Conflicts: # Sources/Data Model/ExperimentCore.swift # Sources/Data Model/Holdout.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's discuss options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We need to add order enforcement as discussed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change. It looks like we need to fix ordering.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good! A few more clean up tips.
Co-authored-by: Jae Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
* master: Experiment id and variation id added into decision notification payload (#589) [FSSDK-11374] add test cases for impression event and decision listener with holdout support (#588) [FSSDK-11373] add holdout support and refactor decision logic in DefaultDecisionService (#587) [FSSDK-11372] assign holdoutIds to feature flags (#578) [FSSDK-11371] parsing holdout section from the datafile (#577) [FSSDK-11111] chore: update cocoapods version (#576) [FSSDK-11102] chore: replace travis-ci-tools repository (#571)
Summary
Test plan
Issues