Skip to content

Accept Mapping as param_distributions in OptunaSearchCV #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Accept Mapping as param_distributions in OptunaSearchCV #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions optuna_integration/sklearn/sklearn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,8 +745,8 @@ def __init__(
) -> None:
_imports.check()

if not isinstance(param_distributions, dict):
raise TypeError("param_distributions must be a dictionary.")
if not isinstance(param_distributions, Mapping):
raise TypeError("param_distributions must be a mapping.")

# Rejecting deprecated distributions as they may cause cryptic error
# when cloning OptunaSearchCV instance.
Expand All @@ -766,7 +766,11 @@ def __init__(
self.max_iter = max_iter
self.n_trials = n_trials
self.n_jobs = n_jobs if n_jobs else 1
self.param_distributions = param_distributions
self.param_distributions = (
param_distributions
if isinstance(param_distributions, dict)
else dict(param_distributions)
)
self.random_state = random_state
self.refit = refit
self.return_train_score = return_train_score
Expand Down
Loading