Skip to content

Conversation

@ParagEkbote
Copy link
Contributor

Motivation

Have less config files to manage.

Description of the changes

Similar to #6292, I have migrated .coveragerc to pyproject.toml. However, there was no gh-action setup for tracking Codecov, so I have used the same job located at .github/workflows/coverage.yml for collecting the test coverage.

Could you please review the changes?

@ParagEkbote
Copy link
Contributor Author

@c-bata Should I just remove the .coveragerc file here and not add codecov tracking?

@c-bata
Copy link
Member

c-bata commented Oct 3, 2025

Thank you for your pull request.

@c-bata Should I just remove the .coveragerc file here and not add codecov tracking?

Yes. Could you simply remove .coveragerc and the codecov's badge on README.md?

@c-bata c-bata self-assigned this Oct 3, 2025
@c-bata c-bata added the other Issue/PR that does not fit into any other label. label Oct 3, 2025
@ParagEkbote ParagEkbote changed the title Add Codecov Tracking and migrate .coveragerc to pyproject.toml Migrate .coveragerc to pyproject.toml Oct 3, 2025
@ParagEkbote
Copy link
Contributor Author

Could you please review?

cc: @c-bata

@ParagEkbote ParagEkbote requested a review from c-bata October 6, 2025 12:08
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-bata c-bata added this to the v4.6.0 milestone Oct 6, 2025
@c-bata c-bata merged commit 0004f49 into optuna:main Oct 6, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

other Issue/PR that does not fit into any other label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants