Use docker/build-push-action to support multi-platform build.
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@y0z Could you review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request updates the Docker image build workflow in
.github/workflows/dockerimage.ymlto modernize the setup and improve maintainability. The key changes include replacing custom scripting with standardized Docker GitHub Actions (see https://github.com/docker/build-push-action) and simplifying the handling of environment variables.This PR will change Docker tags as follows:
Current main:
py3.12will be created, but not pushedv0.1.1andlatestwill be pushed (unchanged)This PR:
ciwill be created but not pushedv0.1.1andlatestwill be pushed (unchanged)Removing the Python version will simplify the CI configuration.
Description of the changes
docker/build-push-action@v6, which supports multi-platform builds and integrates seamlessly with GitHub Actions.PYTHON_VERSIONfrom the environment variables and updated theTAG_NAMElogic to use a static "ci" tag for non-release events.