Skip to content

Conversation

@nabenabe0928
Copy link
Contributor

Contributor Agreements

Please read the contributor agreements and if you agree, please click the checkbox below.

  • I agree to the contributor agreements.

Motivation

As some packages fail with Python 3.9, I added future annotations and modified the PR template accordingly.

Description of the changes

  • add future annotations
  • modify the PR template

@HideakiImamura
Copy link
Member

@not522 Could you review this PR?

@nabenabe0928 nabenabe0928 changed the title Add future annotations as they fail with Python 3.9 Add future annotations as some modules fail with Python 3.9 Sep 30, 2024
@nabenabe0928
Copy link
Contributor Author

@not522 I applied your suggestion, PTAL!!

Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@not522 not522 merged commit 8ff7188 into optuna:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants