Refactor value at risk and add get_robust_trial API
#299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabenabe0928
changed the title
nabenabe0928
changed the title
get_robust_trial API
msakai
reviewed
Sep 25, 2025
Comment on lines
381
to
382
| _sign = np.array([-1.0 if d == StudyDirection.MINIMIZE else 1.0 for d in study.directions]) | ||
| y_train, _, _ = _standardize_values(_sign * np.array([trial.values for trial in trials])) |
Contributor
There was a problem hiding this comment.
Why an underscore (_) is prefixed in the variable _sign?
Local variables starting with an underscore are usually used when the variables are never read, but here the _sign variable is read.
Contributor
Author
There was a problem hiding this comment.
Hi, thank you for the comments:)
I modified accordingly!
msakai
reviewed
Oct 1, 2025
Contributor
msakai
left a comment
msakai
left a comment
There was a problem hiding this comment.
get_robust_trial looks good to me.
y0z
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.