Skip to content

Conversation

@nabenabe0928
Copy link
Contributor

Contributor Agreements

Please read the contributor agreements and if you agree, please click the checkbox below.

  • I agree to the contributor agreements.

Tip

Please follow the Quick TODO list to smoothly merge your PR.

Motivation

Description of the changes

TODO List towards PR Merge

Please remove this section if this PR is not an addition of a new package.
Otherwise, please check the following TODO list:

  • Copy ./template/ to create your package
  • Replace <COPYRIGHT HOLDER> in LICENSE of your package with your name
  • Fill out README.md in your package
  • Add import statements of your function or class names to be used in __init__.py
  • (Optional) Add from __future__ import annotations at the head of any Python files that include typing to support older Python versions
  • Apply the formatter based on the tips in README.md
  • Check whether your module works as intended based on the tips in README.md

@msakai
Copy link
Contributor

msakai commented Sep 25, 2025

suggest_by_carbo no longer uses the best_params argument, so shouldn't we just remove the argument itself?

Alternatively, we could keep the best_params parameter and the code that uses it in suggest_by_carbo, and (temporarily) disable the feature by passing best_params=None when calling suggest_by_carbo from CARBOSampler.sample_relative.

@nabenabe0928
Copy link
Contributor Author

@msakai
Hi thank you for the comment, I removed the best_params completely.

Copy link
Contributor

@msakai msakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@y0z y0z merged commit 462c534 into optuna:main Oct 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants