-
Notifications
You must be signed in to change notification settings - Fork 51
Add empirical attainment surface #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| multiple_study_list.append(study_list) | ||
|
|
||
| plot_multiple_empirical_attainment_surfaces = optunahub.load_module( | ||
| "package/visualization/plot_empirical_attainment_surface" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "package/visualization/plot_empirical_attainment_surface" | |
| "visualization/plot_empirical_attainment_surface" |
| plot_multiple_empirical_attainment_surfaces = optunahub.load_module( | ||
| "package/visualization/plot_empirical_attainment_surface" | ||
| ).plot_multiple_empirical_attainment_surfaces | ||
| ax = plot_multiple_empirical_attainment_surfaces( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error.
Traceback (most recent call last):
ax = plot_multiple_empirical_attainment_surfaces(
multiple_study_list, levels=[3, 5, 7], labels=["Random", "TPE"]
)
TypeError: plot_multiple_empirical_attainment_surfaces() missing 1 required positional argument: 'attainment_ratios'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I renamed the argument, but forgot updating here!
|
@y0z |
|
@nabenabe0928 Thank you for your update. Then, I encountered another issue. The documentation says `attainment_ratios`: The ratios of studies that need to dominate the surface. The length must be either 1 or 3. If the length is 1, the corresponding attainment surface will be visualized.However, I got the following error with ax = plot_multiple_empirical_attainment_surfaces(
multiple_study_list, attainment_ratios=[0.5], labels=["Random", "TPE"]
)
File "/Users/yozaki/.cache/optunahub/github.com/optuna/optunahub-registry/f222e6887cc0b2651d9caa827f73a26437bcaf80/package/visualization/plot_empirical_attainment_surface/_wrapper.py", line 100, in plot_multiple_empirical_attainment_surfaces
ax.legend()
^^^^^^^^^
AttributeError: 'list' object has no attribute 'legend' |
|
@y0z |
y0z
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@nabenabe0928 |
Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.
Tip
Please follow the Quick TODO list to smoothly merge your PR.
Motivation
Description of the changes
TODO List towards PR Merge
Please remove this section if this PR is not an addition of a new package.
Otherwise, please check the following TODO list:
./template/to create your package<COPYRIGHT HOLDER>inLICENSEof your package with your nameREADME.mdin your package__init__.pyfrom __future__ import annotationsat the head of any Python files that include typing to support older Python versionsREADME.mdREADME.md