Skip to content

Conversation

@fusawa-yugo
Copy link
Contributor

Motivation

Documentation pages of optunahub is not styled like that of optuna or optuna-dashboard.
So, I applied css to make the design consistent with other pages.

Description of the changes

I add logo images and custom.css by referring to these in optuna-dashboard.

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (db5f0f2) to head (cb421cd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files           9        9           
  Lines         169      169           
=======================================
  Hits          150      150           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fusawa-yugo fusawa-yugo reopened this Apr 10, 2025
@fusawa-yugo
Copy link
Contributor Author

I'm sorry, I made a mistake when creating this branch.
So there's no need to review this PR at the moment.
I'll fix it later.

@c-bata
Copy link
Member

c-bata commented Apr 14, 2025

I'm sorry, I made a mistake when creating this branch. So there's no need to review this PR at the moment. I'll fix it later.

I see. Let me convert this PR to draft. Please mark as ready for review after you fix the issue.

@c-bata c-bata marked this pull request as draft April 14, 2025 02:37
@fusawa-yugo fusawa-yugo force-pushed the fusawa-yugo/apply-design-template branch from 02d789c to 43207fe Compare April 17, 2025 04:29
@fusawa-yugo
Copy link
Contributor Author

@c-bata
Thank you for changing to draft!
I fixed it and this PR is ready for review.

@fusawa-yugo fusawa-yugo marked this pull request as ready for review April 17, 2025 09:04
@c-bata
Copy link
Member

c-bata commented Apr 17, 2025

@y0z Could you review this PR?

@y0z y0z added the document Documentation related. label Apr 18, 2025
@y0z y0z added this to the v0.3.0 milestone Apr 18, 2025
Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit 8b9778f into optuna:main Apr 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document Documentation related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants