-
Notifications
You must be signed in to change notification settings - Fork 5
Add support for Ubuntu #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Actualy unbreak 18.04 as hexdump used to be in bsdmainutils before being moved to bsdextrautils.
|
On Ubuntu 22.04 and 24.04, |
Not sure about how to handle this. Linux distros trend to switch from Also Linux distros which have switched to systemd.time still provide a cron package that is not installed by default (seems the case of Ubuntu 22.04 and 24.04 according to CI, but I feel like Debian 13 did that too, but the CI image contains cron for some reason). Not managing cron entries on such systems is fine, but after updating from an older operating-system, the cron package will be present, a crontab entry will exist, and the module shall not setup a new systemd.timer entry that unexpectedly duplicate this existing integration. In the choria world, we had a similar issue and "fixed" it by having a Cron is 30 years old and I believe it will still be here in 20 years so this feels a reasonable choice to me. What do you think? |
Newer Linux distributions to not install the cron package by default. While we might be interested in systemd.timer integration in the future, for now just ensure cron is installed, and assume it will be on targetted systems. If this is an issue for some users, they will maybe open a PR to contribute systemd.timer support :-D If so, maybe see this comment: #79 (comment)
|
In the meantime, I ensured cron is installed before running acceptance tests. Support for systemd may be added in a future PR that change how integrations are handled: ensure the one chosen by when user is enabled, and ignore the other (do not ensure it is absent). |
Its the better "fix" is know, go for it. |
|
Would you like to fix it in this PR or in another one? |
Actualy unbreak 18.04 as hexdump used to be in bsdmainutils before being
moved to bsdextrautils.