Fix/#760 chip create reload

[dvlpwork]

Ticket

#760

Summary

The Select option was not updated when the chip was created.

Changes

The hardcoded key ["listChips"] did not match the actual key ["/chips"] used by useListChips, so the cache was never invalidated. Replaced with getListChipsQueryKey() from the generated client.

[claude]

Claude finished @dvlpwork's task —— View job

---

Code Review Complete ✅

Todo List:

• Read and analyze the changed file
• Review code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Assess security concerns
• Review test coverage implications
• Provide comprehensive feedback

---

Review Feedback

✅ Excellent Fix - Well Implemented

This PR correctly addresses issue #760 by fixing the cache invalidation for the chips list after creating a new chip.

What Was Fixed:

• Line 7: Added import for getListChipsQueryKey from the generated client
• Line 103: Replaced hardcoded ["listChips"] with getListChipsQueryKey()

The root cause was a query key mismatch:

• Before: Used hardcoded ["listChips"]
• Actual key: useListChips uses ["/chips"] (as returned by getListChipsQueryKey())
• Result: Cache invalidation failed, Select components didn't update

Code Quality & Best Practices ⭐

• Follows established patterns: Uses the generated query key function instead of hardcoding
• Type safety: Leverages the auto-generated client functions
• Maintainability: If the API endpoint changes, the query key will update automatically
• Consistency: Aligns with the codebase pattern of using generated client functions

Technical Analysis

• No bugs detected: The fix is minimal and targeted
• Performance: No performance impact - same cache invalidation behavior, now working correctly
• Security: No security implications - only affects client-side cache management
• No breaking changes: Internal change that fixes existing functionality

Potential Considerations

1. Test Coverage: Consider adding a test that verifies:

   // After chip creation, verify chips list is refreshed
   expect(queryClient.invalidateQueries).toHaveBeenCalledWith({ 
     queryKey: ["/chips"] 
   });

2. Documentation: The fix aligns perfectly with the CLAUDE.md instruction to "use existing libraries and utilities" - in this case, the generated client functions.

Verdict

This is a high-quality fix that:

• ✅ Correctly identifies and fixes the root cause
• ✅ Uses best practices (generated client functions)
• ✅ Maintains code consistency
• ✅ Is minimal and non-invasive
• ✅ Follows the repository's coding standards

Recommendation: Approve - This fix properly resolves the cache invalidation issue and follows all established patterns.