Skip to content

Work with the changes in the output format of MibS and add test examples for MibS solver #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xuluze
Copy link

@xuluze xuluze commented Nov 10, 2023

This PR tries to make PAO work with MibS as pointed out in #98.
And raise the error if the linking variables are not integer: "ERROR:All linking variables should be integer"
@mkoeppe

@Paulnkk
Copy link

Paulnkk commented Jan 22, 2024

Hey, is there any progress here to merge the PR? I would like to utilise the mibs functionality

@tkralphs
Copy link

tkralphs commented Feb 2, 2024

@whart222 This looks pretty good, what do you think?

@Paulnkk
Copy link

Paulnkk commented Feb 7, 2024

@tkralphs I think I will pull this branch and continue to work on my machine. One problem related question; I want to use MiBS to solve a bi-level problem with lower-level and upper-level MILP (non-separable variables), does that work ?

@VioletIsSoCute
Copy link

@Paulnkk Did you face the problem in #98? I'm facing the same issue and couldn't figure out the solution. Not sure if this happened to you.

@tkralphs
Copy link

tkralphs commented Feb 7, 2025

@VioletIsSoCute So to clarify, this PR is not working for you? This is supposed to fix #98. I have not personally tried using it yet, but it looks correct and seems to be working for @Paulnkk. I can try to look into it if it seems to be broken. I am hoping that @whart222 can take a look at and merge this PR at some point.

@whart222
Copy link
Contributor

whart222 commented Feb 7, 2025

@tkralphs Yeah, this thread highlighted that I had dropped the ball on doing this merge. I'll try to get this done in the next few weeks.

@VioletIsSoCute
Copy link

@tkralphs Yes, #98 is not working for me.

@tkralphs
Copy link

@VioletIsSoCute I guess my question was whether this PR is not working for you. The issue was reported in #98, but this PR was supposed to have fixed it and you seem to be saying that it didn't fix it for you. Is that correct? If so, it might help to say more about what went wrong. If you haven't tried to use this PR, then that might be all you need.

@VioletIsSoCute
Copy link

@tkralphs
Thanks for your follow up, I haven't tested the PR.

After posting the question, I tried to reinstall the MibS solver using coinbrew. However, there is some trouble for running Clp unit test, with error message as bellow:

##################################################

Configuring Clp master

##################################################

##################################################

Building Clp master

##################################################

##################################################

Running Clp unit test

##################################################

Testing ClpSimplex
***Skipped Testing on netlib ***
use -netlib to test class
All tests completed successfully
Testing OsiRowCut with OsiClpSolverInterface
Testing OsiColCut with OsiClpSolverInterface
Testing OsiRowCutDebugger with OsiClpSolverInterface
Testing OsiClpSolverInterface
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
*** clpSolverInterface testing issue: solve model by hand failed: mm->pivot(colIn,colOut,outStatus) >= 0
clp: running common unit tests.
Testing row/column name handling ...
Checking that solver can set row and column solutions ... ok.
Testing loadProblem and assignProblem methods.
Testing writeMps and writeMpsNative.
Testing writeLp and writeLpNative.
Checked 8 hints x (true, false) at strength OsiForceDo; 16 throws.
Testing status for artificial variables.
Skipped Testing of OsiClpSolverInterface on Netlib problems, use -testOsiSolverInterface to run them.
Tests completed with 14 unexpected errors.
make[1]: *** [test] Error 1
make: *** [test] Error 2

Error: Build failed, see error output above

I'm not sure what is happening and could not find a fix for it. Not even sure about the first downloaded version is working or not too (and I deleted it), because I probably ignore the error message.

@tkralphs
Copy link

Hmm, that is odd, but you can safely skip the test with the argument --tests none to coinbrew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants