Skip to content

feat: change the init() to be an explicit action triggered from consumer code #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/js/cerner-smart-embeddable-lib.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

import { Provider } from 'xfc';

const predefinedACLs = [
'https://embedded.cerner.com',
'https://embedded.sandboxcerner.com',
'https://embedded.devcerner.com',
];

/**
* Wrapper object to initialize the provider's content
* to allow content to embed inside an iframe.
Expand All @@ -11,12 +17,10 @@ const CernerSmartEmbeddableLib = {
/**
* Initializes the provider wrapper object with ACLs.
*/
init: () => {
Provider.init({
acls: ['https://embedded.cerner.com',
'https://embedded.sandboxcerner.com', 'https://embedded.devcerner.com'],
});
init: (acls = predefinedACLs) => {
Provider.init({ acls });
},

/**
* Get the frame height. The default height is HTML's scrollHeight.
*/
Expand All @@ -29,6 +33,7 @@ const CernerSmartEmbeddableLib = {
setFrameHeight: (h) => {
Provider.trigger('iframeCustomResizer', { height: h });
},

/**
* Listen for iframeCustomResizer message.
* Calculate the frame height in px and set the height.
Expand Down
12 changes: 7 additions & 5 deletions src/js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@

import CernerSmartEmbeddableLib from './cerner-smart-embeddable-lib';

CernerSmartEmbeddableLib.init();
CernerSmartEmbeddableLib.listenForCustomFrameHeight();
export const initializeCernerSmartEmbeddableLib = (acls) => {
CernerSmartEmbeddableLib.init(acls);
CernerSmartEmbeddableLib.listenForCustomFrameHeight();

window.CernerSmartEmbeddableLib = window.CernerSmartEmbeddableLib || {};
window.CernerSmartEmbeddableLib.calcFrameHeight = CernerSmartEmbeddableLib.calcFrameHeight;
window.CernerSmartEmbeddableLib.setFrameHeight = CernerSmartEmbeddableLib.setFrameHeight;
window.CernerSmartEmbeddableLib = window.CernerSmartEmbeddableLib || {};
window.CernerSmartEmbeddableLib.calcFrameHeight = CernerSmartEmbeddableLib.calcFrameHeight;
window.CernerSmartEmbeddableLib.setFrameHeight = CernerSmartEmbeddableLib.setFrameHeight;
};