[GR-74060] Implement AVX2 and AVX512 paths for byte compress and shift operations#13182
Open
graalvmbot wants to merge 1 commit intomasterfrom
Open
[GR-74060] Implement AVX2 and AVX512 paths for byte compress and shift operations#13182graalvmbot wants to merge 1 commit intomasterfrom
graalvmbot wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements fallback paths for vectorized byte shift and compress operations when no direct AVX512 hardware instructions are available. Shifting is done by extending to a larger element size, using an appropriate shift, and narrowing back. Compress is implemented in terms of 128-bit shuffles; for larger vectors, the final result is assembled on the stack out of the results of compressing 128-bit lanes.
https://github.com/debe/libfindchars benchmark results from my old-ish i9-10920X workstation:
AVX2
AVX512, no VBMI2
The cases where we beat C2 by 5-10x seem to be cases where C2 fails to inline
VectorSupport::compressExpandOpintoByteVector::compressTemplate(callee is too large), at least according to the agent that I asked to look at its logs. Without that, we're broadly on par.