[GR-77108] Prevent outlining separately compiled secondary bytecode switches#13966
Merged
Conversation
…h is compiled separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent handler outlining when a secondary bytecode interpreter switch is compiled as a separate method.
Bytecode DSL may split a large interpreter switch into partition methods such as
continueAt_1. During hosted compilation, these secondary switches are inlined into the primary switch, where their handler calls are outlined normally. Secondary switches can also remain independently callable, including from deoptimization-target code. In that case, their handler calls must remain ordinary calls.Changes
secondarySwitchtoBytecodeInterpreterHandlerConfig.OutlineBytecodeHandlerPhasewhen compiling a secondary switch separately.The primary switch still inlines the secondary switch and outlines its handler calls. Only the independently compiled secondary method is excluded from outlining.