[GR-77580] Centralize handling of negated implication consequents.#13989
Closed
graalvmbot wants to merge 1 commit into
Closed
[GR-77580] Centralize handling of negated implication consequents.#13989graalvmbot wants to merge 1 commit into
graalvmbot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an implication proof (
LogicNode#implies) returns a true/false result for a particular consequent, it should return false/true for the negated consequent. For example:It is unnecessary for every
impliesoverride to handle the negated cases separately. Instead, the override should match positive cases only and delegate to the superclass if the result is unknown. This PR moves the handling of negated consequents toLogicNode#implies, removes theCompareNode#implieslogic that breaks the delegation chain, removes the duplicated negation handling fromIntegerBelowNode, and documents the delegation contract inLogicNode.implies.