Skip to content

Allow skipping sigtest and make it more robust, too #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timfel merged 1 commit into from
Jan 16, 2026
Merged

Allow skipping sigtest and make it more robust, too #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions org.graalvm.python.embedding/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@
<os>
<family>Unix</family>
</os>
<property>
<name>!skipSigtest</name>
</property>
</activation>
<build>
<plugins>
Expand Down
17 changes: 17 additions & 0 deletions scripts/sigtest-check-embedding.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,23 @@ done
project_root="$( cd -P "$( dirname "$source" )/.." && pwd )"

cd "${project_root}"

# If any argument is -s some/path/to/a/settings.xml, check if that file exists
# and if not, create an empty one
was_s=0
for var in "$@"; do
if [[ "$var" == "-s" ]]; then
was_s=1
elif [[ $was_s -eq 1 ]]; then
if [ ! -f "$var" ]; then
mkdir -p "$(dirname "$var")"
echo "$var does not exist"
echo "<settings></settings>" > "$var"
fi
break
fi
done

classpath="$(./mvnw "$@" -q -pl org.graalvm.python.embedding exec:exec -Dexec.executable="echo" -Dexec.args='%classpath')"
exec_args="-BootCP -Static -Mode bin -FileName ./org.graalvm.python.embedding/snapshot.sigtest -ClassPath ${classpath} -b -PackageWithoutSubpackages org.graalvm.python.embedding"
rc=0
Expand Down