Skip to content

Conversation

@ih0r-d
Copy link
Contributor

@ih0r-d ih0r-d commented Jan 18, 2026

Description

Permissions are now stored as VFS metadata and applied on extraction.
This fixes non-executable binaries after extractResources.

Type of change

  • New feature (non-breaking change which adds functionality)

Related to #43

What is changed

Updated VirtualFileSystemImpl to support explicit POSIX file permissions as filesystem metadata instead of relying on implicit or hardcoded executable heuristics.

The VFS now:

  • parses file and directory permissions from fileslist,
  • stores permissions on VFS entries,
  • applies permissions when extracting files and directories,
  • uses declared permissions consistently for access and execution checks.

This makes VFS behavior deterministic and aligned with real filesystem semantics.

How Has This Been Tested?

  • Ran existing VirtualFileSystem unit tests locally after updating them to reflect permission-based behavior.
  • Added coverage for permission propagation during extraction.
  • Verified behavior using local embedding examples that trigger VFS extraction.

Test Configuration:

  • JDK: project default
  • OS: Linux / macOS
  • Build tool: Maven
  • GraalPy: local build (SNAPSHOT)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests validating the new behavior
  • New and existing unit tests pass locally
  • Any dependent changes have been merged and published in downstream modules

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 18, 2026
@ih0r-d ih0r-d changed the title 43: ExtractVirtualFileSystemResources does not set correct permissions ExtractVirtualFileSystemResources does not set correct permissions Jan 18, 2026
@ih0r-d ih0r-d force-pushed the feature/43-extract-vfs-resources-permissions branch from 763c023 to 01f9a4f Compare January 18, 2026 09:13
@ih0r-d ih0r-d force-pushed the feature/43-extract-vfs-resources-permissions branch from 01f9a4f to 7cee664 Compare January 18, 2026 09:18
@ih0r-d ih0r-d force-pushed the feature/43-extract-vfs-resources-permissions branch 2 times, most recently from e00d542 to 5e340eb Compare January 19, 2026 17:51
@ih0r-d ih0r-d force-pushed the feature/43-extract-vfs-resources-permissions branch from 5e340eb to 0c7bdc9 Compare January 19, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants