Merged
Conversation
sid-srini
previously approved these changes
Mar 5, 2025
Member
sid-srini
left a comment
There was a problem hiding this comment.
Thanks a lot @lahodaj and @Achal1607 for bringing these important NBLS changes targeted for future NB releases. LGTM 👍
@Achal1607 - please merge #382 first and rebase on main before merging this. Thanks.
d2cc626 to
801b90f
Compare
Adding patch for NETBEANS-8289
Member
|
LGTM, thank you |
naren2605
pushed a commit
to naren2605/javavscode
that referenced
this pull request
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to backport NB-26 patches which includes necessary bug fixes.