Extension restart fix

[shivam71]

Issue
Post activating the extension one of the two cases happen

1)JDK Found
2) No JDK Found
In case of "No JDK Found" we enter a bad state where even if the user changes the jdk path to some valid path we cannot restart unless the user reloads .

In case initially JDK found but later user changes the path to an invalid jdk home then also we enter No JDK Found state.
Fix
Moved the reload window pop up from jdk downloader to configuration change listener(restartExtension) triggered whenever any configuration is changed and extension is in bad state.
This gives user a prompt to reload window so that extension can come out of the bad state.

[Achal1607]

LGTM. Thank you!

[sid-srini]

Please rebase the branch to main in order to remove unrelated changes in l10n files. Thanks.

--- Update: Sorry, please ignore. I mistook the highlight due to the added , before the necessary changes.

[shivam71]

While checking for the consistency I find that the deactivate function in extension.ts killing the process first

export function deactivate(): Thenable<void> {
    Telemetry.enqueueCloseEvent();
    const process = globalState.getNbProcessManager()?.getProcess();
    if (process != null) {
        process?.kill();
    }
    return globalState.getClientPromise().stopClient();
}

This function is called by vscode only (when closing window) and is for cleaning up . So we can do the following

export function deactivate(): Thenable<void> {
    Telemetry.enqueueCloseEvent();
    const clientStopped = globalState.getClientPromise().stopClient();
    const process = globalState.getNbProcessManager()?.getProcess();
    if (process != null) {
        process?.kill();
    }
    return clientStopped;
}

Note

• Because stopClient is async it doesn't guarantee that client gets stopped first .
• Moreover its not a good idea to await on that because the deactivate function has a time limit of 5 seconds as mentioned (deactivate not wait event it returns a promise microsoft/vscode#114688)

[shivam71]

As per the LSP protocol the client manages the server life cycle .

So as per the protocol the client sends a Shutdown Request to the server indicating the server to prepare for shutdown . The sever must respond with errors if any that happen during the shutdown .

On receiving the Shutdown request's response from the server the client sends an Exit notification which when the server receives must kill itself i.e exit the process .

client.stop() (vscode language client implementation) does exactly this but our netbeans lsp server doesn't implement the exit method so it keeps on running post the exit notification . Hence we have to do the mannual killing afterwards.

Implementing the exit method in the netbeans lsp server will help us avoid this manual killing altogether and make the code easier to understand as well as adhere with the lsp protocol spec.