chore: minor improvements

Signed-off-by: Trong Nhan Mai <[email protected]>
oracle · Jun 14, 2023 · 2cc75c0 · 2cc75c0
1 parent f6d7426
commit 2cc75c0
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/macaron/slsa_analyzer/registry.py b/src/macaron/slsa_analyzer/registry.py
@@ -373,7 +373,6 @@ def get_transitive_children(self, parent_id: str) -> list[str]:
                     if child not in visited:
                         stack.append(child)
                     elif child in stack:
-                        # Circular Dependency.
                         raise CheckCircularDependency("cycle nodes detected")
             else:
                 stack.pop()
@@ -412,7 +411,6 @@ def get_transitive_parents(self, child_id: str) -> list[str]:
                     if parent not in visited:
                         stack.append(parent)
                     elif parent in stack:
-                        # Circular Dependency.
                         raise CheckCircularDependency("cycle nodes detected")
             else:
                 stack.pop()
@@ -488,7 +486,7 @@ def _build_topo_graph(self, ex_pats: list[str], in_pats: list[str]) -> set[str]
             else:
                 final_checks_id = self._get_final_checks(ex_pats, in_pats)
         except (CheckCircularDependency, CheckRegistryError) as error:
-            logger.info(error)
+            logger.error(error)
             return None
 
         for check_id in final_checks_id: