chore: rename get_transitive_closure to get_reachable_nodes

oracle · Feb 21, 2024 · 9347251 · 9347251
1 parent cb847c0
commit 9347251
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/macaron/slsa_analyzer/registry.py b/src/macaron/slsa_analyzer/registry.py
@@ -382,7 +382,7 @@ def get_children(self, check_id: str) -> set[str]:
         return set(self._check_relationships_mapping.get(check_id, {}))
 
     @staticmethod
-    def get_transitive_closure(
+    def get_reachable_nodes(
         node: T,
         get_successors: Callable[[T], Iterable[T]],
     ) -> Iterable[T]:
@@ -462,7 +462,7 @@ def get_final_checks(self, ex_pats: list[str], in_pats: list[str]) -> list[str]:
 
         transitive_ex: set[str] = set()
         for direct_ex in exclude:
-            transitive_children = self.get_transitive_closure(
+            transitive_children = self.get_reachable_nodes(
                 node=direct_ex,
                 get_successors=self.get_children,
             )
@@ -475,7 +475,7 @@ def get_final_checks(self, ex_pats: list[str], in_pats: list[str]) -> list[str]:
 
         transitive_in: set[str] = set()
         for direct_in in include:
-            transitive_parents = self.get_transitive_closure(
+            transitive_parents = self.get_reachable_nodes(
                 node=direct_in,
                 get_successors=self.get_parents,
             )

diff --git a/tests/slsa_analyzer/checks/test_registry.py b/tests/slsa_analyzer/checks/test_registry.py
@@ -408,7 +408,7 @@ def get_successors(start: str) -> set[str]:
                 return set()
 
     assert sorted(
-        Registry.get_transitive_closure(
+        Registry.get_reachable_nodes(
             node=start_node,
             get_successors=get_successors,
         )