CreationTime feature #156
Open
CreationTime feature #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Went through all the tests and checked the results.
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Hi @cezarfx, The changes look good to me, just have a question about naming of getCreationTime() in DeleteResult and WriteMulitpResult. In addition, maybe the new API for creation time and row metadata need to be added to CHANGELOG.md ? |
Put back static imports. Removed EXISTING_CREATION_TIME from protocol and use CREATION_TIME instead. Added extra tests to check creationTime in context of queries on regular/collection tables with/without index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new API to return creation time for a row.