feat(node_info_controller): add providerid to node patch bytes

[pree]

Ref: #522

This fixes it as it sets the already known InstanceID to the nodes.
I've got it deployed in my 3-node Talos cluster right now and it's working like intended.
For anyone who wants to try it out, I've got it build as the image ghcr.io/pree/cloud-provider-oci:v1.34.0

[oracle-contributor-agreement]

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

• PR author: pree
• pascal@reeb.io (@pree)

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

[oracle-contributor-agreement]

Thank you for signing the OCA.

[AkarshES]

@pree will it be possible for you to share the logs without these changes?
Ideally the provider ID is set by the node_controller by invoking the GetInstanceByNodeName method. I want to check is there are any errors while fetching this information.

[pree]

@AkarshES I'm getting the following in the logs:

I0123 01:16:10.293671       1 node_controller.go:429] Initializing node pantheon-control-plane-pjsfk with cloud provider
I0123 01:16:10.821208       1 node_controller.go:233] error syncing 'pantheon-control-plane-pjsfk': failed to get instance metadata for node pantheon-control-plane-pjsfk: error fetching node by provider ID: Failed to map providerID to instanceID, and error by node name: Failed to map providerID to instanceID, requeuing
E0123 01:16:10.821240       1 node_controller.go:244] "Unhandled Error" err="error syncing 'pantheon-control-plane-pjsfk': failed to get instance metadata for node pantheon-control-plane-pjsfk: error fetching node by provider ID: Failed to map providerID to instanceID, and error by node name: Failed to map providerID to instanceID, requeuing" logger="UnhandledError"

But I also don't see how the method you linked sets the ProviderID?

[AkarshES]

GetInstanceByNodeName is invoked by InstanceID, which is called by GetInstanceProviderId from getInstanceMetadata. This is called by syncNode, which sets the providerId if not set already https://github.com/oracle/oci-cloud-controller-manager/blob/master/vendor/k8s.io/cloud-provider/controllers/node/node_controller.go#L498

[pree]

Okay, I've missed that. I was unable to get that matching working at all. Tried multiple thinks, hostname is matching the node name in k8s, I've added DNS regions to match for the hostname, etc. Sadly there is no real debug logging available in the CCM and I'm unsure what needs to be fulfilled. As stated by others I'm not the only one having this issue with the CAPOCI provider.