Features: diagnostics and LS extensions by MischaPanch · Pull Request #1433 · oraios/serena

MischaPanch · 2026-04-28T10:44:51Z

Adds support for diagnostics (JB and LSP); find_implementation and find_definition (LSP)

Removed some cases (haxe, msl) during cherry pick due to conflicts. We don't need to cover these languages in this test

…vior Also minor fix in go test expectations of symbol name

opcode81 · 2026-04-29T23:25:47Z

+        return self._limit_length(result, max_answer_chars)
+
+
+class FindDefiningSymbolTool(Tool, ToolMarkerSymbolicRead):


The implementation of this tool is rather complicated. I think it should be based on the same helper as JetBrainsFindDeclarationTool, which already does all of the heavy lifting.
And we should probably rename it to FindDeclarationTool or FindSymbolDeclarationTool.
wdyt?

Yes, the implementation predates the work you did for the Jetbrains variant on main. I agre to rename to FindDeclaration and to use the same helper as in the JB tool

I consolidated this with f6396f8

opcode81 · 2026-04-29T23:27:59Z

+def _diagnostic_severity_name(severity: int | None) -> str:
+    if severity is None:
+        return "Unknown"
+    try:
+        return DiagnosticSeverity(severity).name
+    except ValueError:
+        return f"Severity_{severity}"
+
+
+def _diagnostic_output_dict(diagnostic: ls_types.Diagnostic) -> dict[str, Any]:
+    result: dict[str, Any] = {
+        "message": diagnostic["message"],
+        "range": diagnostic["range"],
+    }
+    if "code" in diagnostic:
+        result["code"] = diagnostic["code"]
+    if "source" in diagnostic:
+        result["source"] = diagnostic["source"]
+    return result
+
+
+def _add_grouped_diagnostic(
+    grouped_result: dict[str, dict[str, dict[str, list[dict[str, Any]]]]],
+    relative_path: str,
+    severity_name: str,
+    name_path: str,
+    diagnostic: ls_types.Diagnostic,
+) -> None:
+    grouped_result.setdefault(relative_path, {}).setdefault(severity_name, {}).setdefault(name_path, []).append(
+        _diagnostic_output_dict(diagnostic)
+    )
+
+
+def _offset_to_line_and_column(text: str, offset: int) -> tuple[int, int]:
+    if offset < 0 or offset > len(text):
+        raise ValueError(f"Offset out of range: {offset}")
+    prefix = text[:offset]
+    line = prefix.count("\n")
+    previous_newline_offset = prefix.rfind("\n")
+    column = offset if previous_newline_offset == -1 else offset - previous_newline_offset - 1
+    return line, column
+
+
+def _line_and_column_to_offset(text: str, line: int, column: int) -> int:
+    if line < 0 or column < 0:
+        raise ValueError(f"Line and column must be non-negative, got {line=}, {column=}")
+
+    line_start_offsets = [0]
+    for match in re.finditer("\n", text):
+        line_start_offsets.append(match.end())
+
+    if line >= len(line_start_offsets):
+        raise ValueError(f"Line out of range: {line}")
+
+    line_start_offset = line_start_offsets[line]
+    line_end_offset = line_start_offsets[line + 1] - 1 if line + 1 < len(line_start_offsets) else len(text)
+    if column > line_end_offset - line_start_offset:
+        raise ValueError(f"Column out of range for line {line}: {column}")
+    return line_start_offset + column


We should probably move these helpers to the new module ls_diagnostics and encapsulate them in an abstraction. Some of the functionality is probably already duplicated - and this is partly true for the implementation of the diagnostics tools as well.

We need to consolidate this.

Yes, moving there sounds good. You can probably task an agent with deduplication and refactoring, the new tests and the demo script should allow it to perform this without breaking functionality

Duplication of diagnostics-based functionality is now fixed in cdf2481 by introducing new abstraction GroupedDiagnostics. All of the functions were duplicates.

+        for edited_file_path in edited_files:
+            try:
+                language_server = symbol_retriever.get_language_server(edited_file_path.after_relative_path)
+            except:


+                        edited_file_path.after_relative_path,
+                        min_severity=2,
+                    )
+                except:


+        agent.execute_task(lambda: None)
+
+        relative_path = SERVICES_FILE.as_posix()
+        services_abs_path = PYTHON_TEST_REPO / SERVICES_FILE


* Add context manager to simplify usage, improving output handling * Add util module ls_diagnostics, reifying DiagnosticsDiff

Management was unnecessarily introduced by AI in 133e1be

…cation

* Apply common functionality already used in JetBrainsFindDeclarationTool * Remove location-based tool (counteracts Serena's principle to eschew line numbers) * Apply renaming to use "find declaration" instead of "find defining symbol"

…implementations tools

…and_ls_extensions Conflicts: CHANGELOG.md

LS: mark LS that support implementation request

df0f476

MischaPanch force-pushed the features/diagnostics_and_ls_extensions branch 3 times, most recently from 67dfa7b to e901434 Compare April 29, 2026 08:36

github-code-quality Bot found potential problems Apr 29, 2026

View reviewed changes

Comment thread scripts/demo_run_tools.py Dismissed

MischaPanch force-pushed the features/diagnostics_and_ls_extensions branch 2 times, most recently from ed57f0d to 37d8cc9 Compare April 29, 2026 19:33

MischaPanch mentioned this pull request Apr 29, 2026

Fix downloaded dependency versioning #1438

Merged

MischaPanch force-pushed the features/diagnostics_and_ls_extensions branch from 37d8cc9 to 6672a52 Compare April 29, 2026 19:38

MischaPanch requested a review from opcode81 April 29, 2026 19:42

opcode81 changed the title ~~Features: diagnostics and ls extensions~~ Features: diagnostics and LS extensions Apr 29, 2026

github-code-quality Bot found potential problems Apr 29, 2026

View reviewed changes

Comment thread src/serena/util/ls_diagnostics.py Fixed

Comment thread src/serena/util/ls_diagnostics.py Fixed

opcode81 force-pushed the features/diagnostics_and_ls_extensions branch 2 times, most recently from 4e942e2 to 77ad04c Compare April 29, 2026 21:42

MischaPanch and others added 6 commits April 29, 2026 23:52

Diagnostics, implementation and definition tools (WIP)

c55e0c9

Restructured serena_agent tests, reifying the cases

940bbb3

Removed some cases (haxe, msl) during cherry pick due to conflicts. We don't need to cover these languages in this test

Added JetBrains diagnostics tools, WIP

d198d67

Fixed diagnostics files uri handling, added low-level tests

bd7e64e

Fixes in various LS and in tests to accommodate diagnostics edge beha…

da59a19

…vior Also minor fix in go test expectations of symbol name

Refactoring: Introduce base class EditingToolWithDiagnostics

15858e6

opcode81 force-pushed the features/diagnostics_and_ls_extensions branch 2 times, most recently from 4344057 to 7d70d11 Compare April 29, 2026 23:11

opcode81 reviewed Apr 29, 2026

View reviewed changes

Comment thread src/serena/tools/symbol_tools.py Outdated

opcode81 reviewed Apr 29, 2026

View reviewed changes

opcode81 force-pushed the features/diagnostics_and_ls_extensions branch from 7d70d11 to cdf2481 Compare April 30, 2026 09:43

github-code-quality Bot found potential problems Apr 30, 2026

View reviewed changes

opcode81 force-pushed the features/diagnostics_and_ls_extensions branch 3 times, most recently from ed6cd16 to 65cc90b Compare April 30, 2026 12:30

opcode81 force-pushed the features/diagnostics_and_ls_extensions branch from e36ebef to f6396f8 Compare April 30, 2026 13:12

github-code-quality Bot found potential problems Apr 30, 2026

View reviewed changes

Comment thread scripts/demo_find_defining_symbol.py

agent.execute_task(lambda: None)

relative_path = SERVICES_FILE.as_posix()

services_abs_path = PYTHON_TEST_REPO / SERVICES_FILE

opcode81 force-pushed the features/diagnostics_and_ls_extensions branch from 37fab1f to c035ac0 Compare April 30, 2026 13:26

github-code-quality Bot found potential problems Apr 30, 2026

View reviewed changes

Comment thread scripts/demo_diagnostics.py Fixed

opcode81 force-pushed the features/diagnostics_and_ls_extensions branch from c035ac0 to 843277a Compare April 30, 2026 13:31

opcode81 added 5 commits April 30, 2026 15:31

Refactor EditingToolWithDiagnostics

061020c

* Add context manager to simplify usage, improving output handling * Add util module ls_diagnostics, reifying DiagnosticsDiff

CodeEditor: Remove unused management of edited files

5ab912c

Management was unnecessarily introduced by AI in 133e1be

Refactoring: Introduce abstraction GroupedDiagnostics, removing dupli…

371d70f

…cation

Update change log and README to consider new diagnostics/declaration/…

4f0c3f8

…implementations tools

opcode81 force-pushed the features/diagnostics_and_ls_extensions branch from 843277a to 4f0c3f8 Compare April 30, 2026 13:31

Merge remote-tracking branch 'origin/main' into features/diagnostics_…

90d6f2c

…and_ls_extensions Conflicts: CHANGELOG.md

opcode81 merged commit d9d49fa into main Apr 30, 2026
6 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Features: diagnostics and LS extensions#1433

Features: diagnostics and LS extensions#1433
opcode81 merged 13 commits intomainfrom
features/diagnostics_and_ls_extensions

MischaPanch commented Apr 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

opcode81 Apr 29, 2026

Uh oh!

MischaPanch Apr 30, 2026

Uh oh!

opcode81 Apr 30, 2026 •

edited

Loading

Uh oh!

opcode81 Apr 29, 2026 •

edited

Loading

Uh oh!

MischaPanch Apr 30, 2026

Uh oh!

opcode81 Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		return self._limit_length(result, max_answer_chars)


		class FindDefiningSymbolTool(Tool, ToolMarkerSymbolicRead):

Uh oh!

Conversation

MischaPanch commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

opcode81 Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

MischaPanch Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

opcode81 Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

opcode81 Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MischaPanch Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

opcode81 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MischaPanch commented Apr 28, 2026 •

edited

Loading

opcode81 Apr 30, 2026 •

edited

Loading

opcode81 Apr 29, 2026 •

edited

Loading