Set row_step after resizing point cloud#180
Open
HansRobo wants to merge 1 commit intoorbbec:v2-mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I found
row_steperror in Foxglove Studio for point cloud topic from OrbbecSDK_ROS2@c0c14f5 with ORBBEC Femto Boto, like the image below.Solution
Since
raw_stepwas not updated after invalid points were removed, I added a line to update it.And I had no error with the fixed version of

OrbbecSDK_ROS2.Note
sensor_msgs::PointCloud2Modifier::resizeis a function often used to updaterow_step, but if consistency other thanrow_stephas been achieved first, therow_stepupdate will be skipped. https://github.com/ros2/common_interfaces/blob/jazzy/sensor_msgs/include/sensor_msgs/impl/point_cloud2_iterator.hpp#L127-L130