Next #600
Draft
Next #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min-auth-plug fix broken app installation, we need to redirect to shopify for install
- moved to using a body reader for validation - ensure validation moved in to its own plug - all the logic for settings assigns (shop, topic, etc) moved in to its own plug - setup of the route for the webhooks should now happen in the router.ex - handling and business logic for webhooks should now happen in a controller
refactored webhooks
freemer
reviewed
Apr 30, 2025
| @@ -0,0 +1,22 @@ | |||
| defmodule ShopifyAPI.Model.WebhookScope do | |||
There was a problem hiding this comment.
Does Shopify use the term scope to refer to webhooks anywhere? Just curious how you landed on this struct name.
All I could find in Shopify's docs is that the headers contain "webhook metadata". https://shopify.dev/docs/apps/build/webhooks#headers
There was a problem hiding this comment.
I don't think Shopify does but Phoenix is standardizing on this now https://hexdocs.pm/phoenix/1.8.0-rc.2/scopes.html
There was a problem hiding this comment.
They are using it as a way to build up a map of metadata for queries/access/etc
There was a problem hiding this comment.
I suppose this could just be called Scope, but I worry a bit that the app using the library might already be using that
This allows us to use the shopify app toml for creating the App struct
adding a few fields to the App struct and a App.new/1
This uses the now commonly accepted pattern of passing down a scope to requests. The protocol defines how the data from the scope can be accessed. AuthToken has an implementation of the new protocol for backwards compatability reasons.
Add Scopes context and Scope protocol
This greatly simplifies the most common use case, 1 shopify app to one phx app.
new app server single app mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next big ver of shopify api