Skip to content

Conversation

@jshiohaha
Copy link
Contributor

Description

  • Update the rest of the ts-sdk packages to accommodate contract upgrade to Anchor 0.31 and Solana 2.1.0
  • Most changes stem from a change in types from I<type> to <type, e.g. IInstruction -> Instruction
  • XXXn -> BigInt(XXX) changes are due to the following compiler complaint: BigInt literals are not available when targeting lower than ES2020.ts(2737)
  • 📓 tx-sender has the most manual changes, mostly due to types or functions that got moved around. There were also some types that were overly prestrictive. By removing explicit return types, I was able to resolve compiler errors. But please double check the changes in this package.

🔗 for reference, the related PRs:

Test

✅ Packages build:yarn build
✅ tx-sender, whirlpool, core: yarn test

Copy link
Member

@wjthieme wjthieme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjthieme
Copy link
Member

wjthieme commented Oct 2, 2025

XXXn -> BigInt(XXX) changes are due to the following compiler complaint: BigInt literals are not available when targeting lower than ES2020.ts(2737)

Did we lower the target? Why were they available before?

@jshiohaha
Copy link
Contributor Author

jshiohaha commented Oct 3, 2025

XXXn -> BigInt(XXX) changes are due to the following compiler complaint: BigInt literals are not available when targeting lower than ES2020.ts(2737)

Did we lower the target? Why were they available before?

I think the build passed before, I was mostly seeing a bunch of red in my editor from the compiler. I saw we use BigInt other places as well, so I also thought it was nice to consolidate. But, I'm happy to revert if you prefer the XXXn notation 👍

Update: I went ahead and reverted these changes since the packages build with the previous code.

@jshiohaha jshiohaha mentioned this pull request Oct 3, 2025
@jshiohaha jshiohaha force-pushed the TKN-700/ts-sdk-other branch from 480286e to 91fe941 Compare October 3, 2025 16:07
@jshiohaha jshiohaha requested a review from rawfalafel as a code owner October 3, 2025 16:07
@jshiohaha jshiohaha force-pushed the TKN-700/ts-sdk-client branch 2 times, most recently from ff4ce52 to b085062 Compare October 10, 2025 15:08
@jshiohaha jshiohaha force-pushed the TKN-700/ts-sdk-other branch from 91fe941 to e887400 Compare October 10, 2025 15:13
@jshiohaha jshiohaha force-pushed the TKN-700/ts-sdk-client branch from 049d517 to 80ec259 Compare October 19, 2025 22:13
Base automatically changed from TKN-700/ts-sdk-client to TKN-700/base October 19, 2025 22:14
@jshiohaha jshiohaha force-pushed the TKN-700/ts-sdk-other branch from e887400 to 8008810 Compare October 19, 2025 22:18
@jshiohaha jshiohaha merged commit 424c98a into TKN-700/base Oct 19, 2025
@jshiohaha jshiohaha deleted the TKN-700/ts-sdk-other branch October 19, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants