-
Notifications
You must be signed in to change notification settings - Fork 293
update ts-sdk packages: core, tx-sender, whirlpool #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wjthieme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did we lower the target? Why were they available before? |
I think the build passed before, I was mostly seeing a bunch of red in my editor from the compiler. I saw we use BigInt other places as well, so I also thought it was nice to consolidate. But, I'm happy to revert if you prefer the Update: I went ahead and reverted these changes since the packages build with the previous code. |
480286e to
91fe941
Compare
ff4ce52 to
b085062
Compare
91fe941 to
e887400
Compare
049d517 to
80ec259
Compare
e887400 to
8008810
Compare
Description
I<type>to<type, e.g. IInstruction -> InstructionBigInt literals are not available when targeting lower than ES2020.ts(2737)tx-senderhas the most manual changes, mostly due to types or functions that got moved around. There were also some types that were overly prestrictive. By removing explicit return types, I was able to resolve compiler errors. But please double check the changes in this package.🔗 for reference, the related PRs:
Test
✅ Packages build:
yarn build✅ tx-sender, whirlpool, core:
yarn test