Skip to content

Conversation

@jshiohaha
Copy link
Contributor

Description

  • Anchor >=0.31 no longer enforces an 8-byte discriminator. These tests ensure that we do not accidentally introduce a change that impacts existing account discriminators.

Testing

  • Build: anchor build -p whirlpool
  • Unit tests: cargo test -p whirlpool --lib

Copy link
Collaborator

@yugure-orca yugure-orca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost LGTM, but could you check the followings ?

@jshiohaha
Copy link
Contributor Author

jshiohaha commented Oct 17, 2025

almost LGTM, but could you check the followings ?

Thanks for the comments! I replied to most comments directly, but for the last 1 here - I actually based all my tests' name and content on the existing dynamic tick array discriminator test, so I think that case is covered - unless I'm missing smth else 👀

Copy link
Collaborator

@yugure-orca yugure-orca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk for the update!
(sorry I missed the existing test case for DynamicTickArray)

LGTM with 1 super nit.

@jshiohaha jshiohaha merged commit 99363f9 into main Oct 17, 2025
7 checks passed
@jshiohaha jshiohaha deleted the TKN-714 branch October 17, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants