Skip to content

Fix tx-sender changeset to reflect accurate types (KeyPairSigner | NoopSigner) #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Fix tx-sender changeset to reflect accurate types (KeyPairSigner | NoopSigner) #1122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/tx-sender-browser-wallet-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Improve browser wallet compatibility and add configurable transaction sending strategy

**Browser Wallet Support:**
- `buildTransaction` now accepts `TransactionSigner` (KeyPairSigner or NoopSigner) and automatically detects signer type
- `buildTransaction` now accepts `KeyPairSigner | NoopSigner` and automatically detects signer type
- Performs partial signing for NoopSigner (browser wallets), full signing for KeyPairSigner (Node.js)
- `sendTransaction` now accepts `(FullySignedTransaction | Transaction) & TransactionWithLifetime` to support both workflows

Expand All @@ -15,7 +15,7 @@ Improve browser wallet compatibility and add configurable transaction sending st
- Default settings optimized for premium RPCs; public RPC users can configure conservative settings

**Breaking Changes:**
- `buildTransaction` no longer accepts `Address` string parameter. Must pass `TransactionSigner` instance to ensure same object is used for both instruction building and transaction building (required by Solana's `@solana/kit` identity checks).
- `buildTransaction` no longer accepts `Address` string parameter. Must pass `KeyPairSigner | NoopSigner` instance to ensure same object is used for both instruction building and transaction building (required by Solana's `@solana/kit` identity checks).

**Migration:**
```typescript
Expand Down
Loading