[TKN-703, AMM-41] Dockerize CI build, test and lint jobs
#1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use docker compose for build and test jobs. Add vitest and tsup to ts-sdk manifests.
…to changeset CI check.
calintje
added
the
skip-changeset
…rks). Remove memory/kernel settings in CI
wjthieme
reviewed
Nov 7, 2025
| run: yarn install | ||
| - name: Run Lint | ||
| run: yarn lint --output-style static | ||
| - name: Run lint |
Member
There was a problem hiding this comment.
I don't think lint needs anything that is not already installed on a github runner. Doing it in docker might be a little overkill
Contributor
Author
There was a problem hiding this comment.
As we discussed earlier, I will update this once we can add all the rust projects to the same root workspace.
.github/workflows/checks.yml
Outdated
| changeset: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event.pull_request.user.login != 'dependabot[bot]' }} | ||
| if: ${{ !(github.event.pull_request.user.login == 'dependabot[bot]' || contains(github.event.pull_request.labels.*.name, 'skip-changeset')) }} |
Member
There was a problem hiding this comment.
I think you can also just do yarn changeset --empty or something IIRC
calintje
force-pushed
the
calintje/dockerize-ci-build-test
branch
from
21b7e61 to
651f0d1
Compare
calintje
removed
the
skip-changeset
calintje
changed the title
build and test jobsbuild and test jobs
calintje
changed the title
build and test jobsbuild, test and lint jobs
jshiohaha
reviewed
Nov 10, 2025
| "@solana/kit": "^2.3.0", | ||
| "codama": "^1.3.7", | ||
| "typescript": "^5.9.3" | ||
| "tsup": "^8.4.0", |
Contributor
There was a problem hiding this comment.
for my own learning, is there a reason why tsup & vitest were added to some package.json files (other than the root)? maybe smth related to the different docker-compose services?
Contributor
Author
calintje
force-pushed
the
calintje/dockerize-ci-build-test
branch
from
a421ce9 to
118fa30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dockerizes the CI build and test jobs using
docker-composeprofiles, resolving native runner issues and simplifying the CI configuration.Changes
1. Add
testprofile to docker-compose.ymlplatform: linux/amd64for all test services to ensure consistent x86_64 architecturelitesvmnative bindings which depend on glibc 2.39+ (__isoc23_*symbols). Debian Bookworm (rust:1.84.0) only has glibc 2.36.:roflag for test services because Vitest writes temporary config bundles tonode_modules/.vite-temp/when loading config files. This is safe in the test environment and necessary for proper test execution.test-program: Whirlpool Solana program teststest-program-integration: Legacy SDK integration tests (requires Ubuntu 24.04 for litesvm)test-ts-sdk: TypeScript SDK tests (client, core, tx-sender, whirlpool)test-rust-sdk: Rust SDK library tests with--libflag### 2. Fix litesvm test failuresTests usinglitesvmwere failing on native GitHub runners with OOM errors despite having sufficient memory. Analysis revealed this was a platform/environment issue rather than actual memory exhaustion.Solution: Dockerizing tests with Ubuntu 24.04 provides:Consistent glibc 2.39 environmentReliable test runs without OOM failures3. Simplify CI workflows
Replaced multi-step CI jobs with simple docker-compose commands:
Before:
After:
docker compose --profile build up)docker compose --profile test up)4. Add dockerized lint job