Integrate changesets into monorepo #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjthieme
requested review from
odcheung,
philcchen,
rawfalafel and
yugure-orca
as code owners
wjthieme
changed the title
odcheung
approved these changes
Jan 27, 2025
Collaborator
odcheung
left a comment
odcheung
left a comment
There was a problem hiding this comment.
overall looks good. just 1 question on the dependency publish workflow (but not blocking)
Comment on lines
+17
to
+25
| # Patch version numbers for local dependencies | ||
| local_deps=$(jq -r '.dependencies // {} | to_entries | .[] | select(.value == "*") | .key' package.json) | ||
| if [ -n "$local_deps" ]; then | ||
| for dep in $local_deps; do | ||
| latest_version=$(npm view $dep version) | ||
| jq --arg dep "$dep" --arg version "$latest_version" \ | ||
| '.dependencies[$dep] = $version' package.json > tmp.json && mv tmp.json package.json | ||
| done | ||
| fi |
Collaborator
There was a problem hiding this comment.
say you updated common-sdk, i see that this will increment legacy-sdk's version, but will it publish legacy-sdk as well?
Member
Author
There was a problem hiding this comment.
Only packages that have one ore more changesets will be updated. If you update common-sdk and sdd a changeset for common-sdk only common-sdk will get updated
Member
Author
There was a problem hiding this comment.
Only packages that have one ore more changesets will be updated
This was referenced Jan 27, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now updating the packages in the monorepo is either update all of them at once or update none. This is not very efficient and annoying because we get lots of new versions without any changes.
This also allows us to publish the legacy-sdk packages using the same process as the new sdks.
Furthermore we don't really have proper changelogs for the libraries. This enforces PRs to contain a changeset (which will be built into a changelog and determines which packages should be published)