Add support for solana v2 crates to rust client #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugure-orca
approved these changes
Feb 6, 2025
Collaborator
yugure-orca
left a comment
yugure-orca
left a comment
There was a problem hiding this comment.
LGTM!
+1 for solana-v1 feature and the default is v2.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
commit 7c0ed0a Author: Wilhelm Thieme <[email protected]> Date: Tue Feb 11 14:58:03 2025 -0500 Lint commit b0e3949 Merge: 1d5f82f c29eed4 Author: Will <[email protected]> Date: Tue Feb 11 14:51:16 2025 -0500 Merge branch 'main' into wjthieme/client-solana-v2 commit 1d5f82f Author: Will <[email protected]> Date: Tue Feb 11 14:49:45 2025 -0500 Update action.yml commit 55311ec Merge: 6c2b8a1 a2bf808 Author: Will <[email protected]> Date: Mon Feb 10 16:30:54 2025 -0500 Merge branch 'main' into wjthieme/client-solana-v2 commit 6c2b8a1 Author: Wilhelm Thieme <[email protected]> Date: Sat Feb 8 14:15:29 2025 -0500 Tweaks? commit df24a19 Author: Wilhelm Thieme <[email protected]> Date: Fri Feb 7 17:26:02 2025 -0500 Upgrade rustc commit f584b2b Author: Wilhelm Thieme <[email protected]> Date: Fri Feb 7 16:42:31 2025 -0500 Build fix commit eab285e Author: Wilhelm Thieme <[email protected]> Date: Fri Feb 7 16:21:48 2025 -0500 Fix changeset commit 38a22a8 Author: Wilhelm Thieme <[email protected]> Date: Fri Feb 7 16:19:52 2025 -0500 Build fix commit c6e2edb Author: Wilhelm Thieme <[email protected]> Date: Fri Feb 7 15:16:30 2025 -0500 fmt commit 43e0192 Author: Wilhelm Thieme <[email protected]> Date: Fri Feb 7 13:34:13 2025 -0500 Tweaks commit 85ef1e2 Author: Wilhelm Thieme <[email protected]> Date: Fri Feb 7 13:26:46 2025 -0500 Changeset commit 78e301d Author: Wilhelm Thieme <[email protected]> Date: Thu Feb 6 09:50:18 2025 -0500 Build fix commit 38df812 Author: Wilhelm Thieme <[email protected]> Date: Thu Feb 6 09:31:08 2025 -0500 Add support for solana v2 crates to rust client
wjthieme
force-pushed
the
wjthieme/client-solana-v2
branch
from
7c0ed0a to
bb778c4
Compare
|
Hey folks, is there an update on this? |
| "@orca-so/whirlpools-rust": major | ||
| --- | ||
|
|
||
| Add support for solana v2 crates, to use solana v1 with orca_whirlpools_client please use the `solana-v1` feature |
There was a problem hiding this comment.
I need help recovering all my losses coins
Janabreuning67
left a comment
Janabreuning67
left a comment
There was a problem hiding this comment.
Need helps to recover all my losses Crypto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a breaking change, I will bump the major version of the orca_whirlpools_client crate. This version is still backwards compatible with solana v1 crates but the consumer will need to enable the
solana-v1feature.Theoretically I could have also done non-breaking: