Add information on SparseSwap updates to docs #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calintje
requested review from
odcheung,
wjthieme and
yugure-orca
as code owners
yugure-orca
approved these changes
Feb 20, 2025
Collaborator
yugure-orca
left a comment
yugure-orca
left a comment
There was a problem hiding this comment.
Thanks for the update!
LGTM with 1 nit
| Our SDKs account for the possibility of uninitialized tick arrays and can reliably generate valid swap quotes. We highly encourage you to use one of our official SDKs: | ||
| - TS Whirlpools SDK | ||
| - Rust Whirlpools SDK | ||
| - TS Legacy SDK (version > 0.13.14) |
Collaborator
There was a problem hiding this comment.
nit: Based on the Notion desc, minimum version requirement for Legacy SDK is 0.13.4, is there any reason to require > 0.13.14 ? (I think that only the latest version (0.13.15) satisfies this requirement) 🤔
Contributor
Author
There was a problem hiding this comment.
That's a mistake from my side. Will fix and merge. Thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information on SparseSwap updates to docs
Source: https://www.notion.so/orcaso/SparseSwap-Support-053c80f5542d4b22bda641544c5045dc?pvs=4
Updated section
