Event emission #778
Merged
Event emission #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugure-orca
requested review from
odcheung,
philcchen,
rawfalafel and
wjthieme
as code owners
philcchen
approved these changes
Feb 27, 2025
|
|
||
| let pre_sqrt_price_one = whirlpool_one.sqrt_price; | ||
| let (input_amount_one, input_transfer_fee_one, output_amount_one, output_transfer_fee_one) = | ||
| if a_to_b_one { |
Contributor
There was a problem hiding this comment.
nit: I think to reduce branching and enhance readability, I generally like to split the variables prior to function calls, so in this case it might be something like
let (input_amount_one, output_amount_one) = if a_to_b_one {
(swap_update_one.amount_a, swap_update_one.amount_b)
} else {
(swap_update_one.amount_b, swap_update_one.amount_a)
};
let input_transfer_fee_one = calculate_transfer_fee_excluded_amount(&ctx.accounts.token_mint_input, input_amount_one);
let output_transfer_fee_one = calculate_transfer_fee_excluded_amount(&ctx.accounts.token_mint_intermediate, output_amount_one);
Contributor
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Thanks! updated. It is much cleaner 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For event emission release
note: PR59