Fix fetch_positions_for_owner() to perform batch calls

[pauldragonfly]

No description provided.

[wjthieme]

Can you also add this for the ts sdk?

[wjthieme]

Also need a changeset for the TS sdk

[pauldragonfly]

Fixed.

[wjthieme]

nit: Clamp the chunk_size to (0, MAX_CHUNK_SIZE)?

[pauldragonfly]

An iterator over a slice in (non-overlapping) chunks (chunk_size elements at a time), starting at the beginning of the slice.
When the slice len is not evenly divided by the chunk size, the last slice of the iteration will be the remainder.

Clamp is necessary here?

[wjthieme]

Anything less than 1 and more than 100 is invalid

[pauldragonfly]

Fixed.

[wjthieme]

Would be nice if you can make this a separate function as well (like in rust). Something like:

export async function fetchMultipleAccountsBatched<T extends object>(
  rpc: Rpc<GetMultipleAccountsApi>,
  addresses: Address[],
  decoder: (account: MaybeEncodedAccount) => MaybeAccount<T>,
): Promise<MaybeAccount<T>[]> {
  const numChunks = Math.ceil(addresses.length / MAX_CHUNK_SIZE);
  const chunks = [...Array(numChunks).keys()].map((i) =>
    addresses.slice(i * MAX_CHUNK_SIZE, (i + 1) * MAX_CHUNK_SIZE),
  );

  const results: MaybeAccount<T>[] = [];
  for (const chunk of chunks) {
    const chunkResult = await fetchEncodedAccounts(rpc, chunk);
    chunkResult.forEach((account, i) => {
      const data = decoder(account);
      results.push(data);
    });
  }
  return results;
}

[pauldragonfly]

Fixed.