Implements resetPositionRange instructions for ts-sdk #943
Conversation
boosik-sol
requested review from
odcheung,
wjthieme and
yugure-orca
as code owners
| } | ||
| }); | ||
|
|
||
| const testOpenPositionInstructions = async ( |
There was a problem hiding this comment.
what I intend that
- creating a new position
- remove all liquidity
- and reset position range, and check if position is correctly changed.
wjthieme
left a comment
wjthieme
left a comment
There was a problem hiding this comment.
Think we will also need this for the rust-sdk (or will you handle that in a separate PR?
Yes, there are many instructions that are not implemented in rust-sdk, such as |
boosik-sol
force-pushed
the
boosik/impl_reset_position_range_ts_sdk
branch
from
1ce9508 to
721e409
Compare
boosik-sol
force-pushed
the
boosik/impl_reset_position_range_ts_sdk
branch
from
a674c51 to
3664a46
Compare
odcheung
left a comment
odcheung
left a comment
There was a problem hiding this comment.
generally looks good! but i want to push for more unit-tests
| ); | ||
|
|
||
| instructions.push( | ||
| getResetPositionRangeInstruction({ |
There was a problem hiding this comment.
where is this method defined? I don't see it in HEAD or elsewhere
There was a problem hiding this comment.
getResetPositionRangeInstruction is defined at @orca-so/whirlpools-client.
| for (const positionTypeName of positionTypes.keys()) { | ||
| const positionName = `${poolName} ${positionTypeName}`; | ||
| it(`Should reset a position for ${positionName}`, async () => { | ||
| await testResetPositionRange(poolName, positionName); |
There was a problem hiding this comment.
we also need to verify that the reset position ix will fail if the position is not empty and if the user is trying to set it to the same tick range.
There was a problem hiding this comment.
Agree, added more tc for those cases.
boosik-sol
force-pushed
the
boosik/impl_reset_position_range_ts_sdk
branch
from
5028be2 to
70d439e
Compare
| for (const poolName of poolTypes.keys()) { | ||
| for (const positionTypeName of positionTypes.keys()) { |
There was a problem hiding this comment.
i'm a little bummed that vitest doesn't have .each functions where we can declare test variations on like .each on jest!
There was a problem hiding this comment.
wait. seems like it does?
https://vitest.dev/api/#test-for
There was a problem hiding this comment.
oh I am checking :D
There was a problem hiding this comment.
I created a new ticket for this, and will fix this
This PR implements
resetPositionRangeinstructions in typescript-sdk