Fix stack overflow in TickArray to TickArrayFacade conversion #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calintje
requested review from
odcheung,
wjthieme and
yugure-orca
as code owners
yugure-orca
added a commit
that referenced
this pull request
Jul 3, 2025
* Squash commit from variable-tas-release This commit squashes the changes from the branch variable-tas-release. The branch variable-tas-release is based on the original branch wjthieme/variable-tas. Co-authored-by: yugure-orca <[email protected]> * changeset * Fix and test (#982) * changeset update * Update Cargo.lock --------- Co-authored-by: Will <[email protected]> Co-authored-by: Calin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
From<TickArray>forTickArrayFacadeimplementation had a circular reference causing infinite recursion and stack overflow. Specifically, the implementation calledval.into(), which is shorthand forFrom::from(val)and looks for aFrom<TickArray>implementation forTickArrayFacade, resulting in recursively calling itself. This was confirmed with a test that demonstrated the issue by attempting to convert a minimalTickArraytoTickArrayFacade.Changes
val.into()with proper match statement to delegate to specific variant implementations