fix dom order#1041
Open
xJuvi wants to merge 4 commits into
Open
Conversation
Collaborator
(have to open raw log to see it because here interface is broken https://productionresultssa12.blob.core.windows.net/actions-results/61c786a8-6d7d-4461-b807-a38f067dc30e/workflow-job-run-aa80a7e3-d6d7-50a8-97b9-927696a2cc20/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-05-22T12%3A37%3A50Z&sig=zLnveMUHco7EtjMl8bhxSIJVM4brfKQPtL3wX4Nz0js%3D&ske=2026-05-22T15%3A25%3A45Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-05-22T11%3A25%3A45Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-05-22T12%3A27%3A45Z&sv=2025-11-05) |
Contributor
Author
|
@NicolasCARPi I saw this and have to check why the tests are failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a new option to maintain the HTML/DOM order.
At the moment, tom-select adds all selected items at the end in the dom. This is not a bug, it's a feature. With this feature, the users sees on the select input the right order in which the options are selected. The problem is, when using optgroups, the dom is broken because the options inside an optgroup leaving the group and will be placed at the end of the list.
With this PR i implement these changes:
keepOrderis false, the current behavior still exists.keepOrderis true, the DOM will keep the correct order but the user see the selection options in order given by DOM.This PR:
fixes #1040
fixes #938