Add Freshness Badges to FAQ Titles and FAQ Accordion #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raphael-Gregori
changed the title
Contributor
|
Semantically, would it make sense to have the badges outside of the element that contains the question? |
tobie
requested changes
Nov 28, 2025
Comment on lines
13
to
16
| <span class="question-text"> | ||
| {{ faq.question | markdownInline | safe }} | ||
| {% include "components/badges/freshness.njk" %} | ||
| </span> |
Contributor
There was a problem hiding this comment.
It would be more semantically correct here to move the components out of the <span class="question-text">.
Contributor
Author
There was a problem hiding this comment.
definitely better !
Contributor
There was a problem hiding this comment.
We want them in the same place visually as they were before.
src/faq/faqs.njk
Outdated
Comment on lines
16
to
18
| <h1 class="section-header"> | ||
| {{ faq.question | markdownInline | safe }} | ||
| {% include "components/badges/freshness.njk" %} |
Contributor
There was a problem hiding this comment.
The components really belong outside of the <h1>. Maybe you'll need to add a <header> around it to make it work.
Contributor
Author
There was a problem hiding this comment.
It definitely seems cleaner !
Contributor
There was a problem hiding this comment.
No, we want them in the same place visually, but not inside of the h1
Raphael-Gregori
force-pushed
the
add-freshness-badge-to-title
branch
from
6a27984 to
9dff6ff
Compare
Raphael-Gregori
force-pushed
the
add-freshness-badge-to-title
branch
from
9dff6ff to
43bc463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the "freshness" badge directly inline with FAQ titles in both single FAQ pages and accordion views, making it immediately visible when viewing FAQ questions.
Changes:
The badge now appears inline immediately after FAQ titles for FAQs created within the last 30 days, in
both individual FAQ pages and FAQ accordion lists. In those specific cases, you don't have to toggle admin info.
Closes #189