Skip to content

Conversation

@lifofifoX
Copy link
Collaborator

Titles look much nicer than larger inscription numbers.

image

@cbspears
Copy link
Contributor

Big fan of this idea. Maybe consider moving the inscription # to a subheading underneath & slightly darker grey just for clarity.

@lifofifoX lifofifoX force-pushed the replace-number-with-title branch from 22fa025 to 58e26f4 Compare December 11, 2025 18:09
@lifofifoX
Copy link
Collaborator Author

@cbspears Good call. Updated it.

image

@lifofifoX lifofifoX force-pushed the replace-number-with-title branch 3 times, most recently from 43e3b4b to 94ccfd9 Compare December 15, 2025 19:17
@lifofifoX lifofifoX requested review from casey and raphjaph December 16, 2025 15:30
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lifofifoX I'm very much in favor of displaying the title, if present, with the inscription number.

However, I'm not sure about the inconsistency of some inscriptions having inscription numbers at the top, and others having titles at the top. For example, what if someone creates an inscription with the title Inscription 0. This could be deceptive.

How about we add the title under the inscription number, if present. So inscription number still always gets the <h1>, and title gets <p>, and later we can discuss swapping them, or otherwise changing the emphasis?

The reason the title should get <p> instead of <hN> is because it doesn't contribute to the structure of the document, it's just a sub-title. We can use CSS to style the <p> however though.

@lifofifoX lifofifoX force-pushed the replace-number-with-title branch from 94ccfd9 to 1a72d0c Compare December 21, 2025 07:05
@lifofifoX
Copy link
Collaborator Author

@casey That seems pretty reasonable. Made the changes and attached screenshots showing the changes.

Inscription
image

Gallery
image

@lifofifoX lifofifoX requested a review from casey December 21, 2025 13:37
@casey casey force-pushed the replace-number-with-title branch from daf8800 to 08d65c0 Compare December 21, 2025 21:05
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made a few changes:

  • The CSS class is .subtitle, since that reflects its role on the page, even if it contains the title property.
  • Instead of using negative margin, we remove the bottom margin from h1s that are immediately followed by a .subtitle
  • Use & instead of as_ref
  • I don't think color: var(--light-fg) was doing anything, so I removed it

@casey casey enabled auto-merge (squash) December 21, 2025 21:08
@casey casey merged commit 3ac44dc into ordinals:master Dec 21, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants