-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use title instead of inscription number when present #4449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Big fan of this idea. Maybe consider moving the inscription # to a subheading underneath & slightly darker grey just for clarity. |
22fa025 to
58e26f4
Compare
|
@cbspears Good call. Updated it.
|
43e3b4b to
94ccfd9
Compare
casey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lifofifoX I'm very much in favor of displaying the title, if present, with the inscription number.
However, I'm not sure about the inconsistency of some inscriptions having inscription numbers at the top, and others having titles at the top. For example, what if someone creates an inscription with the title Inscription 0. This could be deceptive.
How about we add the title under the inscription number, if present. So inscription number still always gets the <h1>, and title gets <p>, and later we can discuss swapping them, or otherwise changing the emphasis?
The reason the title should get <p> instead of <hN> is because it doesn't contribute to the structure of the document, it's just a sub-title. We can use CSS to style the <p> however though.
94ccfd9 to
1a72d0c
Compare
|
@casey That seems pretty reasonable. Made the changes and attached screenshots showing the changes. |
daf8800 to
08d65c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I made a few changes:
- The CSS class is
.subtitle, since that reflects its role on the page, even if it contains the title property. - Instead of using negative margin, we remove the bottom margin from
h1s that are immediately followed by a.subtitle - Use
&instead ofas_ref - I don't think
color: var(--light-fg)was doing anything, so I removed it



Titles look much nicer than larger inscription numbers.