Add full COP-1 compatiblity to the EDL command shell#90
Open
sneakyaardvark wants to merge 9 commits into
Open
Conversation
Hunter-McClellan
approved these changes
Jun 29, 2026
Hunter-McClellan
left a comment
Contributor
There was a problem hiding this comment.
Looks good from what I can see.
I'd appreciate the terminology in the test script being changed to refer to the sdls header instead of the sdls insert zone, as the way that we're doing things is technically out of spec (but the best way given that spacepackets.py lacks sdls support).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds FOP-1 for sending commands to the C3 with the EDL command shell. It is a bare implementation, it does not have the procedures normally sitting between the user and COP. Instead, it uses the internal COP signals directly. This is a simplification for an already complicated implementation of FOP.
Using COP in a shell environment is a little finicky, so by default FOP-1 starts in a clean, active state. If at any time COP times out or fails, expedited (BD) service is always available, or can be explicitly enabled by manually terminating the AD service (
cop_terminate). The AD service can be restarted using thecop_initcommand. Not sure what state COP is in? usecop_status.This also fixes several bugs encountered during implementation: