Skip to content

Add full COP-1 compatiblity to the EDL command shell#90

Open
sneakyaardvark wants to merge 9 commits into
masterfrom
cop-fop
Open

Add full COP-1 compatiblity to the EDL command shell#90
sneakyaardvark wants to merge 9 commits into
masterfrom
cop-fop

Conversation

@sneakyaardvark

Copy link
Copy Markdown
Contributor

This adds FOP-1 for sending commands to the C3 with the EDL command shell. It is a bare implementation, it does not have the procedures normally sitting between the user and COP. Instead, it uses the internal COP signals directly. This is a simplification for an already complicated implementation of FOP.

Using COP in a shell environment is a little finicky, so by default FOP-1 starts in a clean, active state. If at any time COP times out or fails, expedited (BD) service is always available, or can be explicitly enabled by manually terminating the AD service (cop_terminate). The AD service can be restarted using the cop_init command. Not sure what state COP is in? use cop_status.

This also fixes several bugs encountered during implementation:

  • SDLS is incorrectly expected for BC frames. SDLS must not protect COP-1 management frames.
  • Match FARM configuration to the default expected parameters for FOP-1
  • SDO commands were not being parsed correctly in the command shell

@Hunter-McClellan Hunter-McClellan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I can see.

I'd appreciate the terminology in the test script being changed to refer to the sdls header instead of the sdls insert zone, as the way that we're doing things is technically out of spec (but the best way given that spacepackets.py lacks sdls support).

Comment thread tests/protocols/test_uslp.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants