AE-841: command executor now throws when pod creation fails#320
Open
jkrae-metaeffekt wants to merge 3 commits intomasterfrom
Open
AE-841: command executor now throws when pod creation fails#320jkrae-metaeffekt wants to merge 3 commits intomasterfrom
jkrae-metaeffekt wants to merge 3 commits intomasterfrom
Conversation
this means that now, instead of shrugging when the state isn't "Running", we throw a CommandExecutionFailed from the constructor to signify failure to initialize. this gives the environment the opportunity to fail at initialization instead of waiting for timeouts when the first command can't run properly.
jkrae-metaeffekt
force-pushed
the
AE-841-command-executor-init-early-throw
branch
from
c239e87 to
5dcfbb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this means that now, instead of shrugging when the state isn't "Running", we throw a CommandExecutionFailed from the constructor to signify failure to initialize. this gives the environment the opportunity to fail at initialization instead of waiting for timeouts when the first command can't run properly.
Change breaks artifact-analysis without AE-841 merged there, as the environment now will have to catch the checked exception.