Various HTTP/XROOTD changes#4926
Merged
Merged
Conversation
eisenhauer
commented
Mar 7, 2026
eisenhauer
commented
Member
- Switch to GET in https/xrootd URLs. Still parse old for now.
- fine tune curl wait loop to avoid busy-wait and reduce cpu overhead
- increase CampaignReaders' thread cap to improve HTTP get throughput
- Add retry logic for transient HTTP failures.
Member
Author
|
@pnorbert The thread count and curl loop changes here produced about 2.5x speedup in remote fetching in the torture test. The cost is (very) occasional http retries. That might go away if we go to production. This change switches the type of URL we are sending the server. For now the server accepts both new and old. When all of your work is migrated, then we can kill the old stuff. Here GET replaces POST and /adios replaces /ssi. |
Strip the '/' separator left after removing /adios prefix from the URL path. Include exc.what() in batchget error responses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Avoids double-slash ambiguity in URL paths for absolute filenames. Reverts server-side leading-slash stripping since all paths are now absolute. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pnorbert
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.