Add OpenChain() to NullTransport so that BP5 can use it.#5047
Merged
Conversation
Contributor
|
looks good to me but Greg is more knowledgeable in these modules |
eisenhauer
approved these changes
May 21, 2026
eisenhauer
left a comment
eisenhauer
left a comment
Member
There was a problem hiding this comment.
Looks fine, but I'm vaguely curious why the OpenChain isn't Null itself.
Contributor
Author
|
I just wanted it to work the same way as in other transports, i.e. serialize the callers. Open() has some intializations to make sure the calls work as expected but I did not analyze what is really necessary and what is not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.