BP5: 32 Bit Crashes Fixed, 32bit-32bit Round-Trips#5104
Open
ax3l wants to merge 2 commits into
Open
Conversation
Ensures BP5 can round-trip on 32bit. Does not yet support cross-bitness portability to 64bit written hosts and back.
ax3l
changed the title
ax3l
changed the title
Member
|
I've been thinking that coding agents might finally make 32-bit support, and maybe even interoperability, practical... |
Contributor
Author
|
I was thinking the same. I have a bitop commit locally that looks similar + a bit wild that I can submit separately if you like 😅 |
Member
Submit the bitop fix. (Assume this is the BitField operations, which aren't written in a portable way for 32-bit.) That's a nice separable thing that we can change without dealing with more global interoperability concerns... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures BP5 can round-trip writes & reads on 32bit. So far, ADIOS2 BP5 simply segfaulted when used on 32bit systems (tested on Linux, Windows).
Does not yet support cross-bitness portability to 64bit written hosts and back.
Credits to Codex + Claude for the typing.
cc @eisenhauer @pnorbert