Skip to content

Conversation

@michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

  • Reduction in space required for a single experiment logged on mlflow.
  • Zip models before being uploaded to mlflow.

Type of Change

Please select the one relevant option below:

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

quadra_export.generate_torch_inputs(input_size, device=device, half_precision=half_precision),
)
types_to_upload = config.core.get("upload_models")
mlflow_zip_models = config.core.get("mlflow_zip_models")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visto che è un boolean, mettiamo False come valore di default invece che lasciare None

base_dir=model_name,
)
shutil.move("assets.zip", temp_dir)
with mlflow.start_run(run_id=mlflow_logger.run_id) as _:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perchè fai partire la run tutte le volte invece che farlo una sola volta fuori?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perché prima veniva fatto così, veniva fatta partire per onnx e per torch, cambio e metto un'unica run fuori

@lorenzomammana lorenzomammana self-assigned this Dec 3, 2025
@lorenzomammana lorenzomammana merged commit 5df3bdc into main Dec 3, 2025
1 check passed
@lorenzomammana lorenzomammana deleted the feature/compress-models-uploaded-to-mlflow branch December 3, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants