State machine execution logic #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon each step, first the run state is executed and then transitions are checked. If a transition is valid, it is executed upto the entry state of the next state. Executing run is then a task for the next step again. Signed-off-by: Peter Soetens <[email protected]> Conflicts: rtt/scripting/StateMachine.cpp
We should only runState when the previous run finished. Signed-off-by: Peter Soetens <[email protected]>
…tivate() The removed line triggered a failed assert in StateMachine::enableEvents(). Signed-off-by: Johannes Meyer <[email protected]>
This patch prevents that the OperationCaller falls back to a RemoteOperationCaller implementation and logs a warning during the test. Signed-off-by: Johannes Meyer <[email protected]>
Yielding in the run program of state INIT already triggers the global transition to the FINI state, before the send event can be processed and trigger a transition to NEXT. This patch adds a condition to the global transition that only evaluates to true after the run program has finished. Signed-off-by: Johannes Meyer <[email protected]>
Signed-off-by: Peter Soetens <[email protected]>
meyerj
changed the title
This was referenced Feb 9, 2016
Merged
Signed-off-by: Johannes Meyer <[email protected]>
…reCheck() See also commit f6c8c80 and #113. Signed-off-by: Johannes Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the state machine execution logic in a non-backwards compatible way, but does introduce clear semantics of what is done when and in which step of the TaskContext.
Open questions: